Allow providing absolute path to the certificate file when executing scons #10943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, discovered when working on #10493
Summary of the issue:
When wanting to self-sign NVDA launcher it is not possible to provide absolute path to the certificate file. This is not documented, error given by certutil when this is done is quite cryptic but more importantly storing certificate inside the repo increases chances of committing it mistakenly to the public.
Description of how this pull request fixes the issue:
Sconscript used to sign appx version of NVDAno longer assumes that the given path starts at the top dir of the repo. If the path is absolute it is used as is, if not it is being joined with the top directory of the repo.
Testing performed:
With the following layout:
tried the following scons invocations from the top dir of the repo:
scons launcher appx certFile=d:\selfsigned.pfx
scons launcher appx certFile=appveyor\selfsigned.pfx
scons launcher appx certFile=..\..\selfsigned.pfx
In all cases signing process succeeded
Known issues with pull request:
Change log entry:
Either none or:
Changes for developers: