Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 of refactor LiveText to use diff-match-patch #11639

Merged
merged 62 commits into from
Dec 31, 2020
Merged

V2 of refactor LiveText to use diff-match-patch #11639

merged 62 commits into from
Dec 31, 2020

Commits on Sep 19, 2020

  1. Refactor LiveText to use diff-match-patch via IPC with a C++ process.

    @codeofdusk
    codeofdusk committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    8b1ff14 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Explain magic numbers.

    @codeofdusk
    codeofdusk committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    bddf453 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. switch to a Python implementation of nvda_dmp. This commit definitely… 

    … requires that NVDA be run from source!
    @codeofdusk
    codeofdusk committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    59cfbb5 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Compile nvda_dmp as an exe. 

    This also adds the DMP Python extension to the repo, but I'm unsure if it should be in a different location.
    @codeofdusk
    codeofdusk committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    816ea00 View commit details
    Browse the repository at this point in the history

  2. Move import.

    @codeofdusk
    codeofdusk committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    74ac3b3 View commit details
    Browse the repository at this point in the history

  3. Uniformize ends of inserted chunks.

    @codeofdusk
    codeofdusk committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    7bc466e View commit details
    Browse the repository at this point in the history

  4. s/available/supported in config, for consistency with rest of code an… 

    …d to more accurately describe behaviour.
    @codeofdusk
    codeofdusk committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    1e4b3f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Add diffing algorithm to devInfo.

    @codeofdusk
    codeofdusk committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    917a903 View commit details
    Browse the repository at this point in the history

  2. Fix docs/comments

    @codeofdusk
    codeofdusk committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    5fbe33d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Switch to a submodule.

    @codeofdusk
    codeofdusk committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    998c851 View commit details
    Browse the repository at this point in the history

  2. Fix source copies.

    @codeofdusk
    codeofdusk committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    a7abf02 View commit details
    Browse the repository at this point in the history

  3. Use absolute path to nvda_dmp.

    @codeofdusk
    codeofdusk committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    f12e2ba View commit details
    Browse the repository at this point in the history

  4. Allow NVDA to still function if a component changes the current direc… 

    …tory (nvaccess#11650)

* nvda.pyw: ensure that all paths coming from commandline arguments are made absolute as soon as possible  to protect against the current directory changing later on.
Also store NVDA's app dir in globalVars.

* Use the NVDA app dir rather than the current directory for relative paths.

* Fix unit tests.

* Remove all usage of os.getcwd and replace it with globalVars.appDir

* Replace all remaining os.path.join("* calls with os.path.join(globalVars.appDir calls.

* nvda.pyw: provide an absolute path to gettext.translate

* nvda_slave: set globalVars.appDir, and provide an absolute path to gettext.translate

* getDefaultLogFilePath no longer uses the current directory.

* brailleTables: TABLES_DIR is no longer relative to the current directory.

* ui.browsableMessage no longer uses a relative path to get to the html file.

* Change all playWavefile calls to be non-relative

* Fix linting issues

* another relative wave file path

* Fix linting issues

* speechDictHandler: the path to builtin.dic is no longer relative.

* config: slave_fileName is no longer relative

* Lilli braille driver: path to dll is no longer relative.

* Fix linting issues

* nvda_slave: don't load nvdaRemote with a relative path.

* Remove all usage of os.path.abspath, but add a couple of assertions in places where we can't be completely sure the path is absolute.

* Fix translation comments

* Add the ALTERED_LIBRARY_SEARCH_PATH constant to winKernel and use it in NVDAHelper and nvda_slave when loading NvDAHelperRemote.

* Lili  braille dirver: remove unneeded import.

* Update what's new
    @michaelDCurran
    michaelDCurran authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    ba42885 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Merge branch 'master' into livetext-dmp-cpp

    @codeofdusk
    codeofdusk committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    430f24d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/nvaccess/nvda

    @codeofdusk
    codeofdusk committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    6850cb1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into livetext-dmp-cpp

    @codeofdusk
    codeofdusk committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    fec7cdf View commit details
    Browse the repository at this point in the history

  4. Add comment.

    @codeofdusk
    codeofdusk committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    03b4eb9 View commit details
    Browse the repository at this point in the history

  5. Update build script pythonpath.

    @codeofdusk
    codeofdusk committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    5f18189 View commit details
    Browse the repository at this point in the history

  6. Move import

    @codeofdusk
    codeofdusk committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    834e698 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Address review actions.

    @codeofdusk
    codeofdusk committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    74c418f View commit details
    Browse the repository at this point in the history

  2. Don't restrict DMP setting to 1607+. 

    Although it doesn't work on non-enhanced legacy consoles, there are other LiveText objects where DMP would theoretically be supported.
    @codeofdusk
    codeofdusk committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    114ab85 View commit details
    Browse the repository at this point in the history

  3. Update user guide to clarify availability.

    @codeofdusk
    codeofdusk committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    e58a0d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Move to a class-based approach.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    4140003 View commit details
    Browse the repository at this point in the history

  2. Change the DMP setting to a three-way option.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    46eccea View commit details
    Browse the repository at this point in the history

  3. Add logging, update comment.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    0b3c59f View commit details
    Browse the repository at this point in the history

  4. Fix one last comment.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    ec879e6 View commit details
    Browse the repository at this point in the history

  5. Address review actions.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    6fd1fbe View commit details
    Browse the repository at this point in the history

  6. Review actions.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    9b6761d View commit details
    Browse the repository at this point in the history

  7. Add docstrings.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    561ef04 View commit details
    Browse the repository at this point in the history

  8. Change UI to show actual diff algorithms.

    @codeofdusk
    codeofdusk committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    efba5d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Review actions.

    @codeofdusk
    codeofdusk committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    139d345 View commit details
    Browse the repository at this point in the history

  2. Update source/diffHandler.py 

    Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>
    @codeofdusk @feerrenrut
    codeofdusk and feerrenrut authored Oct 9, 2020
    Configuration menu
    Copy the full SHA
    250841e View commit details
    Browse the repository at this point in the history

  3. Remove prefer.

    @codeofdusk
    codeofdusk committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    abfb69f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Fix accelerator.

    @codeofdusk
    codeofdusk committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    63aae02 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into livetext-dmp-cpp

    @codeofdusk
    codeofdusk committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    9d52372 View commit details
    Browse the repository at this point in the history

  3. Centralize config check.

    @codeofdusk
    codeofdusk committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    eb32b26 View commit details
    Browse the repository at this point in the history

  4. Update user guide.

    @codeofdusk
    codeofdusk committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    8438518 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Re-centralize _get_diffAlgo on the LiveText object, but add a compreh… 

    …ensive docstring to clarify expectations for downstream users.

I think the code is easier to reason about this way.
    @codeofdusk
    codeofdusk committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    3fa0b39 View commit details
    Browse the repository at this point in the history

  2. Update nvda_dmp.

    @codeofdusk
    codeofdusk committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    f119840 View commit details
    Browse the repository at this point in the history

  3. Cleanup.

    @codeofdusk
    codeofdusk committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    a4a6ec5 View commit details
    Browse the repository at this point in the history

  4. s/prefer/allow

    @codeofdusk
    codeofdusk committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    ecf2967 View commit details
    Browse the repository at this point in the history

  5. Move config check.

    @codeofdusk
    codeofdusk committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    4e1aceb View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Merge branch 'master' into livetext-dmp-cpp

    @codeofdusk
    codeofdusk committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    094244c View commit details
    Browse the repository at this point in the history

  2. Review actions.

    @codeofdusk
    codeofdusk committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    25e2810 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Merge branch 'master' into livetext-dmp-cpp

    @codeofdusk
    codeofdusk committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    4190423 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Review actions.

    @codeofdusk
    codeofdusk committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    f0a0141 View commit details
    Browse the repository at this point in the history

  2. Sync.

    @codeofdusk
    codeofdusk committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    9b53399 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Update user_docs/en/userGuide.t2t 

    Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>
    @codeofdusk @feerrenrut
    codeofdusk and feerrenrut authored Oct 21, 2020
    Configuration menu
    Copy the full SHA
    a89a4fe View commit details
    Browse the repository at this point in the history

  2. Remove unneeded type checks in legacy console.

    @codeofdusk
    codeofdusk committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    279cbd4 View commit details
    Browse the repository at this point in the history

  3. Fix comments.

    @codeofdusk
    codeofdusk committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    bfc85e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Review actions.

    @codeofdusk
    codeofdusk committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    afb4a76 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Review actions.

    @codeofdusk
    codeofdusk committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    71da66a View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Review actions.

    @codeofdusk
    codeofdusk committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    2174191 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Wait for NVDA_dmp to exit, and throw an exception if it doesn't withi… 

    …n five seconds.
    @codeofdusk
    codeofdusk committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    1eecdfb View commit details
    Browse the repository at this point in the history

  2. Don't set _proc to None on termination, so that _initialize cannot be… 

    … called twice.
    @codeofdusk
    codeofdusk committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    578ab7d View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Review action.

    @codeofdusk
    codeofdusk committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    47b0c13 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Remove _getTextLines entirely, as this PR has been retargetted for 20… 

    …21.1.
    @codeofdusk
    codeofdusk committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    b4f65fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into livetext-dmp-cpp

    @codeofdusk
    codeofdusk committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    dbd8ad8 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. Merge branch 'master' into livetext-dmp-cpp

    @codeofdusk
    codeofdusk committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    16db1a9 View commit details
    Browse the repository at this point in the history

  2. Update user guide (s/2020.4/2021.1) as PR was held back.

    @codeofdusk
    codeofdusk committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    7a8d579 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Merge remote-tracking branch 'origin/master' into livetext-dmp-cpp

    @feerrenrut
    feerrenrut committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    d890ac9 View commit details
    Browse the repository at this point in the history

  2. update changes file for PR nvaccess#11639

    @feerrenrut
    feerrenrut committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    78e4012 View commit details
    Browse the repository at this point in the history