Synth drivers/eSpeak NG internal: pass in a NULL pointer (path string) when obtaining eSpeak NG version string #11975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion info. Python 3.8: without passing in a path string, access violation is thrown, which can cause NVDA executable to hang when trying to obtain eSpeak NG version string. Therefore pass in NULL (None) because what NVDA is interested in is synthesizer version.
See test results for failed build of commit f155bc4941 |
lukaszgo1
suggested changes
Dec 27, 2020
source/synthDrivers/_espeak.py
Outdated
| #Copyright (C) 2007-2017 NV Access Limited, Peter Vágner | ||
| #This file is covered by the GNU General Public License. | ||
| #See the file COPYING for more details. | ||
| # synthDrivers/_espeak.py |
There was a problem hiding this comment.
Please remove this line to comply with the standard for copyright headers.
source/synthDrivers/_espeak.py
Outdated
| @@ -369,7 +369,8 @@ def terminate(): | |||
| onIndexReached = None | |||
|
|
|||
| def info(): | |||
| return espeakDLL.espeak_Info() | |||
| # Python 3.8: a path string must be specified, a NULL is fine when what we need is version string. | |||
| return espeakDLL.espeak_Info(None) | |||
There was a problem hiding this comment.
Since this function returns bytes, and the only place in which it is used is the message in the log stating which version of eSpeak is in use have you considered decoding this to avoid leading "b" being shown in the log viewer i.e.:
return espeakDLL.espeak_Info(None).decode()
|
Hi, should we also remove encoding statement at the top of the file? If yes, I’ll do that while addressing comments. As for encoding from bytes to str, I’ll do that once Grep tells me it is safe to do so. Thanks.
|
Comment from Lukasz Golonka: remove file name from copyright header, use bytes.decode to transform eSpeak NG version string from bytes to Unicode.
See test results for failed build of commit 63aca1d339 |
michaelDCurran
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Needed for Python 3.8, although it is equally applicable to Python 3.7 and makes NVDA code more compliant with eSpeak NG API:
Link to issue number:
None
Summary of the issue:
eSpeak NG fails to load on Python 3.8 version of NVDA, traced to espeak.dll::espeak_Info function not receiving path string.
Description of how this pull request fixes the issue:
Pass in NULL (None) when eSepak NG asks for path string in sepak_Info function because what NVDA is interested in is eSpeak NG version string.
Testing performed:
Tested under source code and via a private binary copy:
Known issues with pull request:
None
Change log entry:
None
Impact:
This is one of the major changes required to move NVDA to Python 3.8, especially given that eSpeak NG will be set as default speech synthesizer on Windows releases other than 10.
Thanks.