implement deprecation of SAYALL behaviour for speakTextInfo #12150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #12123
Implements deprecation announced in: #10878
Summary of the issue:
sayAllHandler was changed to use
speakWithoutPauses
as a default. Developers wanting to use the original behaviour ofspeech.speakTextInfo
with reason as SAYALL should usesayAllHandler
Description of how this pull request fixes the issue:
speakTextInfo
will no longer send speech throughspeakWithoutPauses
if reason isSAYAll
, assayAllhandler
does this manually now.Testing strategy:
Search the code base for usages of
SAYALL
and confirm the only ones that are being set are within sayAllHandler, which handles this behaviour and doesn't trigger deprecation warnings.Manual testing of "say all" behaviour - such as reading all the text or controls of a document may help confirm this and would trigger the deprecations warnings now if this wasn't handled correctly.
Known issues with pull request:
None
Change log entry:
Developer Changes
Code Review Checklist: