Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always reset speechWithoutPauses instance when sayAll cancelled #12396

Merged
merged 1 commit into from
May 12, 2021
Merged

always reset speechWithoutPauses instance when sayAll cancelled #12396

merged 1 commit into from
May 12, 2021

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented May 11, 2021 •
edited
Loading

Link to issue number:

None

Summary of the issue:

The function header for sayAllHandler is incorrect, and the behaviour of cancelling sayAll speech changed in #12251

See the change of behaviour as noted here:

Description of how this pull request fixes the issue:

Restores intended change of behaviour in #12251

Testing strategy:

TBD

Known issues with pull request:

None

Change log entries:

None, message in changelog already

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd seanbudd mentioned this pull request May 11, 2021
Merged
7 tasks
@seanbudd seanbudd marked this pull request as ready for review May 11, 2021 06:04
@seanbudd seanbudd requested a review from a team as a code owner May 11, 2021 06:04
@seanbudd seanbudd added this to the 2021.1 milestone May 11, 2021
feerrenrut
feerrenrut approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @seanbudd

@seanbudd seanbudd merged commit 5d4e64f into master May 12, 2021
@seanbudd seanbudd deleted the reset-swpi branch May 12, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feerrenrut feerrenrut feerrenrut approved these changes

@michaelDCurran michaelDCurran Awaiting requested review from michaelDCurran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2021.1
Development

Successfully merging this pull request may close these issues.
2 participants
@seanbudd @feerrenrut