Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively register for UIA events by default on SV2 #14018

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Aug 16, 2022

Link to issue number:

Partial mitigation for #11002.
Follow-up of #11214 and #13297.

Summary of the issue:

NVDA 2020.3 introduced support for selective registration for UIA events based on the currently-focused provider, but this is disabled by default due to bugs in the Windows 10 task manager and emoji panel.
These bugs have been fixed in Windows 11 SV2.

Description of how this pull request fixes the issue:

By default, enable selective UIA event registration on Windows 11 Sun Valley 2 (22H2).

Testing strategy:

Enable by default in master snapshots to allow for wider testing.

Known issues with pull request:

None known.

Change log entries:

=== Bug Fixes ===

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@AppVeyorBot
Copy link

See test results for failed build of commit 89c42fd0ad

@seanbudd
Copy link
Member

@codeofdusk since @Qchristensen already approved the user docs changes in #13297, before they were split across PRs, I'm going to go ahead and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants