Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConsoleWindowClass to badUIAWindowClasses as the UIA implementation for win32 Console windows is not usable yet. #7497

Merged
merged 2 commits into from
Aug 15, 2017

Conversation

michaelDCurran
Copy link
Member

Link to issue number:

None

Summary of the issue:

In Windows 10 build 16257, Microsoft introduced a UIA implementation for Win32 console windows. Not only does this conflict with our existing support, their UIA implementation is not yet complete (I.e. caret support is lacking, and most likely no useful events for new text).
As this implementation will be in the Fall Creaters update released before NVDA 2017.4, we should for now ignore this UIA implementation, and revisit how we should handle it properly if the implementation improves.

Description of how this pull request fixes the issue:

ConsoleWindowClass is added to _UIAHandler.badUIAWindowClasses.

Testing performed:

  • Started a cmd prompt from the run dialog
  • Started Ubuntu from the Start Screen
  • Started NVDA from an existing Ubuntu session

All of these tests showed NVDA functioning the way it used to before the new UIA implementation in 16257.

Known issues with pull request:

None.

Change log entry:

Probably none needed as getting this in 2017.3 before the general public notice would be good.

…on for win32 Console windows is not usable yet.
Copy link
Contributor

@jcsteh jcsteh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the rest of the entries in this list don't have comments, but I think it'd be good to have a brief comment here (and for future entries) stating why it was added; i.e. why this implementation is problematic for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants