Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service-level change event and sound metadata #34

Merged
merged 4 commits into from
Apr 19, 2017
Merged

Add service-level change event and sound metadata #34

merged 4 commits into from
Apr 19, 2017

Conversation

jkeen
Copy link
Contributor

@jkeen jkeen commented Apr 11, 2017

@noslouch

After committing this I'm hesitating on this hifi-audio-changed name. What about current-sound-changed?

@jkeen
Copy link
Contributor Author

jkeen commented Apr 11, 2017

@noslouch I agree. current-sound-changed makes sense because the current sound is changing, and that also makes sense why it would only be fired on the service and not on the sound. I made that change

@jkeen jkeen force-pushed the feature/new-event-and-metadata branch from 445c7ef to 5c103c5 Compare April 19, 2017 18:52
@jkeen jkeen merged commit 0d98754 into master Apr 19, 2017
@jkeen jkeen deleted the feature/new-event-and-metadata branch June 1, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jkeen