ovirt_disk: dont move disk when already in storage_domain (#135)

* ovirt_disk: dont move disk when already in storage_domain * add fragment
oVirt · Oct 6, 2020 · 2bc5a34 · 2bc5a34
1 parent ec98950
commit 2bc5a34
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/changelogs/fragments/ovirt_disk-fix-move.yml b/changelogs/fragments/ovirt_disk-fix-move.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - ovirt_disk - dont move disk when already in storage_domain (https://github.com/oVirt/ovirt-ansible-collection/pull/135)
diff --git a/plugins/modules/ovirt_disk.py b/plugins/modules/ovirt_disk.py
@@ -606,6 +606,8 @@ def update_storage_domains(self, disk_id):
         # Initiate move:
         if self._module.params['storage_domain']:
             new_disk_storage_id = get_id_by_name(sds_service, self._module.params['storage_domain'])
+            if new_disk_storage_id in [sd.id for sd in disk.storage_domains]:
+                return changed
             changed = self.action(
                 action='move',
                 entity=disk,