Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_disk add warning for DiskAttachments params #347

Merged
merged 5 commits into from
Sep 20, 2021
Merged

ovirt_disk add warning for DiskAttachments params #347

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
984e171
ovirt_disk add warning for DiskAttachments params
mnecas Sep 20, 2021
e1cba55
add changelogs
mnecas Sep 20, 2021
cfd10d9
fix pep8
mnecas Sep 20, 2021
a7ec275
fix flake8
mnecas Sep 20, 2021
2909a78
fix pep8
mnecas Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions plugins/modules/ovirt_disk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,14 @@ def main():
)
elif state == 'detached':
ret = disk_attachments_module.remove()
elif any([
module.params.get('interface'),
module.params.get('activate'),
module.params.get('bootable'),
module.params.get('uses_scsi_reservation'),
module.params.get('pass_discard'),
]):
module.warn("Cannot use 'interface', 'activate', 'bootable', 'uses_scsi_reservation' or 'pass_discard' without specifing VM.")

# When the host parameter is specified and the disk is not being
# removed, refresh the information about the LUN.
Expand Down