Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Preserve environment variables when calling a command #784

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

matejmatuska
Copy link
Member

When calling a command with _call and env parameter is not None,
create and modify a copy of caller process environment variables and
call the command with the copy in order to preserve them.

Jira ref: OAMG-7203

When calling a command with `_call` and `env` parameter is not `None`,
create and modify a copy of caller process environment variables and
call the command with the copy in order to preserve them.

Jira ref: OAMG-7203
@github-actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
  • /rerun-all to schedule all tests (including sst) using this pr build and leapp-repository*master* as artifacts
  • /rerun-all 42 to schedule all tests (including sst) using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@centos-ci
Copy link

Can one of the admins verify this patch?

@leapp-bot
Copy link
Collaborator

This PR has been linked in issue tracker (#OAMG-7209).

@vinzenz vinzenz merged commit 351cfe7 into oamg:master Jul 20, 2022
@vinzenz
Copy link
Member

vinzenz commented Jul 20, 2022

Very nice, thanks a lot!

@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Aug 23, 2022
pirat89 added a commit to pirat89/leapp that referenced this pull request Aug 23, 2022
## Packaging
-  bumped leapp-framework to 3.1 (oamg#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​oamg#784)
- Ignore invalid FQDNs (oamg#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788)
- Introduce `is_inhibitor` function (oamg#677)
- Introduce a `Blob` model field (oamg#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (oamg#785)
- Requires to be executed by root only (oamg#775)
@pirat89 pirat89 mentioned this pull request Aug 23, 2022
pirat89 added a commit to pirat89/leapp that referenced this pull request Aug 23, 2022
## Packaging
-  bumped leapp-framework to 3.1 (oamg#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​oamg#784)
- Ignore invalid FQDNs (oamg#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788)
- Introduce `is_inhibitor` function (oamg#677)
- Introduce a `Blob` model field (oamg#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (oamg#785)
- Requires to be executed by root only (oamg#775)

Signed-off-by: Petr Stodulka <pstodulk@redhat.com>
MichalHe pushed a commit that referenced this pull request Aug 23, 2022
## Packaging
-  bumped leapp-framework to 3.1 (#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​#784)
- Ignore invalid FQDNs (#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (#677, #781, #788)
- Introduce `is_inhibitor` function (#677)
- Introduce a `Blob` model field (#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (#785)
- Requires to be executed by root only (#775)

Signed-off-by: Petr Stodulka <pstodulk@redhat.com>

Signed-off-by: Petr Stodulka <pstodulk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants