Python-3.12 compat and refactor of path determination. #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `stdlib._call()`, we lookup whether the command to call is present on the user's PATH. Two changes are made to this functionality: * Simplify the lookup of PATH now that we have a local variable with all the information we need. * Add compat code to use `shutil.which()` on Python3 (while still using `distutils.spawn.find_executable()` on Python2). As noted in pstodulk's comment, `which()` will be needed when the code runs on Python-3.12.
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
pirat89
requested changes
Oct 19, 2023
pirat89
approved these changes
Oct 24, 2023
pirat89
added
the
changelog-checked
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
stdlib._call(), we lookup whether the command that we are going to call is present on the user's PATH. Two changes are made to the function:shutil.which()on Python3 (while still usingdistutils.spawn.find_executable()on Python2). As noted in the comment,which()will be needed when the code runs on Python-3.12.