Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise subclasses of 'subdivision of oviduct' #3317

Closed
aleixpuigb opened this issue Jul 25, 2024 · 3 comments · Fixed by #3319
Closed

Revise subclasses of 'subdivision of oviduct' #3317

aleixpuigb opened this issue Jul 25, 2024 · 3 comments · Fixed by #3319

Comments

@aleixpuigb
Copy link
Collaborator

aleixpuigb commented Jul 25, 2024

Exploring CL, we have found that there are cell types from endometrium and vagina that wrongly classified as part_of fallopian tube. This is caused as oviduct in Uberon comprises from the ovaries until the exterior of the body:

A tube or collection of tubes in an animal from the ovaries to the outside of the body.

Therefore, uterus and vagina are 'subdivision of oviduct. However, the logical definition of 'fallopian tube' is:

'subdivision of oviduct' and ('part of' some oviduct) and ('develops from' some 'Mullerian duct')

The uterus and the upper part of the vagina develop from the 'Mullerian duct' (although in Uberon only 'upper part of vagina' contains the axiom), resulting in being classified as part of the 'fallopian tube'.

Therefore, the logical definition of 'fallopian tube' should be removed.

Moreover, 'oviduct epithelium' is part_of the 'fallopian tube'. This should be the opposite in agreement with the current definitions of oviduct and fallopian tube.

cc @cmungall what do you think of these proposed changes? For reference, I think you added this editor note to oviduct:

sometimes oviduct is used interchangeably with follaopian tube. Here they are different - the oviduct connects the gonad to the outside in a variety of animals. The mammal-class fallopian tube is derived from the mullerian duct and connects the gonads/infubdibulum to the uterus

@dosumis
Copy link
Contributor

dosumis commented Jul 26, 2024

Oviduct epithelium has

image

Removing the incorrect assertion that this epithelium is part_of some fallopian tube removes all the incorrect inference of shared tissues and cell types between uterus and fallopian tube

image

This fix works even without the change recommended above. That changes =>

image

->
image

This is OK because we still have part relationships to group

image

@dosumis
Copy link
Contributor

dosumis commented Jul 26, 2024

I'd also suggest renaming left and right uterine tube to left and right fallopian tube and making the current names synonyms

image

@aleixpuigb
Copy link
Collaborator Author

I'd also suggest renaming left and right uterine tube to left and right fallopian tube and making the current names synonyms

And for consistency also 'fimbria of uterine tube'.

aleixpuigb added a commit that referenced this issue Jul 26, 2024
Fixes #3317 Fallopian tube hierarchy and relabel
aleixpuigb added a commit that referenced this issue Aug 5, 2024
* Fixes #3317 Fallopian tube hierarchy and relabel

Fixes #3317 Fallopian tube hierarchy and relabel

* Relabels structures from 'X of uterine tube' to 'X of fallopian tube'

* Change wrong axiom

It was using 'mucosa of uterine tube', which has been relabeled as 'mucosa of uterus', which it doesn't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants