-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise subclasses of 'subdivision of oviduct' #3317
Labels
Comments
And for consistency also 'fimbria of uterine tube'. |
aleixpuigb
added a commit
that referenced
this issue
Jul 26, 2024
Fixes #3317 Fallopian tube hierarchy and relabel
aleixpuigb
added a commit
that referenced
this issue
Aug 5, 2024
* Fixes #3317 Fallopian tube hierarchy and relabel Fixes #3317 Fallopian tube hierarchy and relabel * Relabels structures from 'X of uterine tube' to 'X of fallopian tube' * Change wrong axiom It was using 'mucosa of uterine tube', which has been relabeled as 'mucosa of uterus', which it doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Exploring CL, we have found that there are cell types from endometrium and vagina that wrongly classified as part_of fallopian tube. This is caused as oviduct in Uberon comprises from the ovaries until the exterior of the body:
Therefore, uterus and vagina are 'subdivision of oviduct. However, the logical definition of 'fallopian tube' is:
'subdivision of oviduct' and ('part of' some oviduct) and ('develops from' some 'Mullerian duct')
The uterus and the upper part of the vagina develop from the 'Mullerian duct' (although in Uberon only 'upper part of vagina' contains the axiom), resulting in being classified as part of the 'fallopian tube'.
Therefore, the logical definition of 'fallopian tube' should be removed.
Moreover, 'oviduct epithelium' is part_of the 'fallopian tube'. This should be the opposite in agreement with the current definitions of oviduct and fallopian tube.
cc @cmungall what do you think of these proposed changes? For reference, I think you added this editor note to oviduct:
The text was updated successfully, but these errors were encountered: