Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerated allen atlases #1406

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Regenerated allen atlases #1406

wants to merge 1 commit into from

Conversation

cmungall
Copy link
Member

@cmungall cmungall commented Mar 6, 2018

Note there is a spurious diff in here - it makes it look like some IDs were deleted; just order shuffling (sorry, should have normalized ordering)

@matentzn
Copy link
Contributor

Who would be an appropriate reviewer for this PR? @cmungall

@cmungall
Copy link
Member Author

@tgbugs or @dosumis. I simply forget what the current status is with IDs and the Allen Atlases

@tgbugs
Copy link
Contributor

tgbugs commented Dec 13, 2019

The MBA changes look ok to me. The ids are more or less completely arbitrary at this point (much to the consternation of some atlas implementers), still no change to the fact that all the ontology ids share the same uri prefix in the Allen api (http://api.brain-map.org/api/v2/data/Structure/).

@matentzn matentzn marked this pull request as draft July 21, 2021 09:43
@matentzn
Copy link
Contributor

If to be moved forward needs to be aligned with new Makefile structure. Can help but needs driver.

@dosumis
Copy link
Contributor

dosumis commented Jul 21, 2021

ABA Uberon mappings are important for the Brain Data Standards grant, so work can be done @hkir-dev (+ Shawn & Allen representatives if needed). This is currently low on our priority list so won't happen straight away. We should organise a call to work out what needs to be done. Can be after summer.

@gouttegd
Copy link
Collaborator

gouttegd commented Dec 7, 2023

Presumably we can close here?

For all 5 Allen atlases (HBA / DHBA / MBA / DMBA / PBA) that we include in composite-metazoan, we now use the pre-built ontologies provided by https://github.com/brain-bican, so there’s no more need to re-generate them ourselves.

As for the addition of the “glioblastoma” atlas:

  • Is it really something that should be included in composite-metazoan? My feeling is that Uberon (and its composite products) should only be about “normal” / “wild-type” anatomy, and that describing pathological anatomical structures does not belong here.
  • In this PR, allen-glioblastoma.obo is constructed exactly as allen-hba.obo – both files are constructed from the same JSON file: http://api.brain-map.org/api/v2/structure_graph_download/10.json – I assume this is a mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants