Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2952 terminal bronchiole part of secondary pulmonary lobule #2953

Merged

Conversation

aleixpuigb
Copy link
Collaborator

@aleixpuigb aleixpuigb commented Jul 6, 2023

Addresses #2952 terminal bronchiole part of secondary pulmonary lobule.
@JoshuaFortriede, as some of the information about it was a bit ambiguous (see ticket #2952), I would appreciate if you could confirm that this edits are appropriate? Thank you!

Addresses #2952 terminal bronchiole part of secondary pulmonary lobule
@aleixpuigb aleixpuigb requested a review from a user July 13, 2023 09:02
@@ -43847,7 +43847,7 @@ property_value: structure_notes "lacks submucosa and cartilage plates; they have
[Term]
id: UBERON:0002187
name: terminal bronchiole
def: "The last conducting structure of non-respiratory bronchioles; after this point, the airways have alveoli in their walls." [ISBN:0-397-51047-0, MGI:cwg, MP:0002268]
def: "A bronchiole that is part of a secondary pulmonary lobule and the last conducting structure of non-respiratory bronchioles; after this point, the airways have alveoli in their walls." [ISBN:0-397-51047-0, MGI:cwg, MP:0002268, PMID:16543587]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the ambiguity you detail in the linked issue, keeping the original definition (which doesn't seem contested) and using the relationship "overlaps" may be a less controversial solution. Will defer to @JoshuaFortriede or another SME for confirmation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webb 2006 (paywall article) states:

Each secondary lobule is supplied by a small bronchiole

and Ohno 2021 states:

The secondary pulmonary lobule is supplied by a lobular bronchiole

These definitions match my understanding; that the primary bronchiole is the street into the neighborhood (secondary pulmonary lobule), and the terminal bronchioles are the main streets contained within that neighborhood. As such, I believe the new definition works.

I would also suggest adding that the terminal bronchiole is between the primary bronchiole and respiratory bronchiole. Specifically the terminal is distal to the primary, and proximal to the respiratory.

Here is my cheat sheet that I made to keep these airways/structures and space/segments together. The "Type" or RO might not be completely accurate.
image

Copy link
Collaborator Author

@aleixpuigb aleixpuigb Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your input and clarification, @JoshuaFortriede. The cheat sheet is very useful!

I would also suggest adding that the terminal bronchiole is between the primary bronchiole and respiratory bronchiole. Specifically the terminal is distal to the primary, and proximal to the respiratory.

In a different ticket #2957 I have already added 'terminal bronchiole' SubclassOf ' distally connected to' some 'respiratory bronchiole'. However, mice have none or few respiratory bronchioles, and therefore 'terminal bronchioles' are connected to alveolar ducts. Therefore I will have to revert that axiom in a different ticket. On the other side, the lobular bronchiole can be found between the primary bronchiole and the respiratory bronchiole. I would like to investigate a bit more before adding that axiom.

image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using singular form in the def:

A bronchiole that is part of a secondary pulmonary lobule and the last conducting structure of a non-respiratory bronchiole; after this point, the airways have alveoli in their walls.

@@ -43862,6 +43862,7 @@ xref: SCTID:278981008
xref: UMLS:C0225666 {source="ncithesaurus:Terminal_Bronchiole"}
xref: Wikipedia:Terminal_bronchiole
is_a: UBERON:0002186 ! bronchiole
relationship: part_of UBERON:0010369 ! secondary pulmonary lobule
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. Consider overlaps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given Joshua's comment, I think part_of is ok

@aleixpuigb aleixpuigb requested a review from a user July 18, 2023 12:29
@aleixpuigb aleixpuigb merged commit 106246f into master Jul 18, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 2952_terminal_bronchiole-secondary_pulmonary_lobule branch July 18, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relationship between 'terminal bronchiole' and 'secondary pulmonary lobule'
2 participants