Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CARO in domain/range with UBERON terms #695

Closed
Tracked by #1881
anitacaron opened this issue Mar 13, 2023 · 17 comments
Closed
Tracked by #1881

Replace CARO in domain/range with UBERON terms #695

anitacaron opened this issue Mar 13, 2023 · 17 comments
Assignees
Labels

Comments

@anitacaron
Copy link
Collaborator

Related to obophenotype/cell-ontology#1867

A new subset was defined in UBERON to replace CARO ontology.

@balhoff, could you please give instructions on how to use the subset in this case?

@balhoff
Copy link
Member

balhoff commented Mar 13, 2023

I've just opened a relevant issue for Uberon: obophenotype/uberon#2835

But also I think just referencing the terms and doing an ordinary import module extraction via ODK should work.

@ddooley
Copy link
Contributor

ddooley commented May 23, 2023

These are the needed CARO - UBERON substitutions, and we'll need an UBERON import module for them. Jim will provide mapped terms, Damion will do the replacement; Anita, can you prepare the UBERON import file?

image

@balhoff
Copy link
Member

balhoff commented May 23, 2023

Most of these are easy, except for two:

@balhoff
Copy link
Member

balhoff commented May 23, 2023

@gouttegd I think you have grappled with 'connected anatomical structure' recently. We don't seem to have a direct replacement from Uberon. Do you think we can just use 'material anatomical entity' in its place in RO?

@balhoff
Copy link
Member

balhoff commented May 23, 2023

@cmungall any thoughts on replacing organism or virus or viroid?

@bpeters42
Copy link
Collaborator

bpeters42 commented May 23, 2023 via email

@balhoff
Copy link
Member

balhoff commented May 23, 2023

Thanks for pointing that out @bpeters42 — I guess that means that #716 is a prerequisite, so we can use that COB term.

@gouttegd
Copy link
Collaborator

@balhoff

I think you have grappled with 'connected anatomical structure' recently

I’ve had this misfortune, yes. :D

We don't seem to have a direct replacement from Uberon. Do you think we can just use 'material anatomical entity' in its place in RO?

I think it can actually be replaced by Uberon’s anatomical structure. Though it’s not obvious from the label,1 the term has a text definition that clearly states that it refers to a connected structure (“Material anatomical entity that is a single connected structure […]”), it has connected anatomical structure as an exact synonym, and it is cross-referenced to CARO’s connected anatomical structure.

Footnotes

  1. If I remember correctly, the fact that the label does not make it obvious the term refers to something connected was the cause of most of the problems I had to deal with, because people had used the term for things that were not connected, probably because they didn’t check the textual definition.

@balhoff
Copy link
Member

balhoff commented May 23, 2023

@gouttegd thanks! I updated the list above.

@ddooley
Copy link
Contributor

ddooley commented May 23, 2023

@anitacaron is it possible to get the UBERON import module pull request first, then I can do the substitution.

@ddooley
Copy link
Contributor

ddooley commented May 23, 2023

@bpeters42 I open up COB and see "organism" is CARO:0001010 . Is that intentional? It would mean CARO is still needed in RO! It seems cob-to-external indicates equivalency to both OBI and CARO organism.

@bpeters42
Copy link
Collaborator

bpeters42 commented May 23, 2023 via email

@ddooley
Copy link
Contributor

ddooley commented May 23, 2023

Ok, I'll have replacement list switch organism to OBI:0100026 .

@balhoff
Copy link
Member

balhoff commented May 24, 2023

@ddooley Uberon import is available now.

@ddooley
Copy link
Contributor

ddooley commented May 26, 2023

One question about that. Whats the difference in ro-odk.yaml in products: section between module type minimal vs filter? Why is uberon a filter module_type whereas pato is a minimal one? I tried switching the uberon one and couldn't really see a difference. I made the new obi module a minimal one, and have imported it.

- id: uberon
  module_type: filter
- id: obi
  make_base: TRUE
  module_type: minimal

I realize COB might be a source of terms, but then we get into task of needing to have COB load up all the ones referenced for import in RO.

@matentzn
Copy link
Contributor

@ddooley there used to be a bigger difference between filter and minimal, right now the only one is that minimal will not automatically delete object properties if they are not included in the seed, while filter strictly only includes what is in the seed. For most cases, we should use filter.

anitacaron pushed a commit that referenced this issue Jun 12, 2023
* Add OBI as source for organism

Will switch to COB once it has OBI:0100026

* CARO to UBERON term replacement

Note a number of object property domain and range get switched.

* makefile simplification

* Update src/ontology/catalog-v001.xml

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

* Update src/ontology/catalog-v001.xml

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

* Update src/ontology/ro-edit.owl

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

* Update src/ontology/ro-edit.owl

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>

* extra slash

* drops neuron projection bundle parenting to UBERON_0001062

* Update catalog-v001.xml

---------

Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
@wdduncan
Copy link
Collaborator

Closed via #722.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants