Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution Cleanup #664

Merged
merged 6 commits into from
Jan 7, 2023
Merged

Attribution Cleanup #664

merged 6 commits into from
Jan 7, 2023

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Jan 6, 2023

I've been meaning to demonstrate that doing what @cmungall suggested in cthoyt/orcidio#5 was feasible. This PR consists of about a half hour of find/replace in the ro-edit.owl file in a text editor where I replaced string mentions of people's names in provenance fields with canonical ORCID identifiers as URIs. I put a decent debt in this repository's provenance debt (i.e., turning unstructured provenance into structured provenance).

If this PR is accepted, here are some future to-do's:

  1. Continue updating the remaining instances dc, dcterms, dce, and iao annotations that point to individuals
  2. Import ORCIDIO so all of these beautiful, clean ORCID identifiers get names overlayed when editing in Protege
  3. After finishing 1) to completion, add additional unit tests to make sure nobody ever adds unstructured information again (@matentzn I hope you could help introduce this one predicate at a time, perhaps starting with IAO_0000117 since this is fully cleaned up now)

@wdduncan wdduncan self-assigned this Jan 6, 2023
@cthoyt cthoyt mentioned this pull request Jan 6, 2023
@cooperl09
Copy link
Contributor

This looks correct? https://orcid.org/0000-0001-6996-0040

Co-Authored-By: Laurel Cooper <cooperl@oregonstate.edu>
@cthoyt
Copy link
Collaborator Author

cthoyt commented Jan 7, 2023

This looks correct? https://orcid.org/0000-0001-6996-0040

Thanks! Updated in 0c12077

@cmungall cmungall merged commit 6431491 into oborel:master Jan 7, 2023
@cthoyt cthoyt deleted the cleanup-attribution branch January 7, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants