Relax the range restriction on 'has soma location'. #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'has soma location' (RO:0002100) should not have a range restriction to CARO's 'connected anatomical structure' (CARO:0000003), but rather to 'material anatomical entity' (CARO:0000006), which does not state anything about the "connectedness" of the entity that a neuron's soma may be located in. closes #702
dosumis
requested changes
Mar 29, 2023
src/ontology/ro-edit.owl
Outdated
| @@ -1670,15 +1670,15 @@ SubObjectPropertyOf(obo:RO_0002092 obo:RO_0002091) | |||
| # Object Property: obo:RO_0002100 (has soma location) | |||
|
|
|||
| AnnotationAssertion(obo:IAO_0000114 obo:RO_0002100 obo:IAO_0000125) | |||
| AnnotationAssertion(obo:IAO_0000115 obo:RO_0002100 "Relation between a neuron and an anatomical structure that its soma is part of."@en) | |||
| AnnotationAssertion(obo:IAO_0000115 obo:RO_0002100 "Relation between a neuron and an anatomical entity that its soma is part of."@en) | |||
There was a problem hiding this comment.
Maybe specify 'material' anatomical entity here?
Make sure the text definition of 'has soma location' is aligned with the range restriction and refers to a *material* anatomical entity.
dosumis
approved these changes
Mar 29, 2023
|
That’s ~590 unsatisfiability issues gone away with a one-line change. 🎉 “Never in the history of ontology editing have so many unsats been fixed by so few changes.” — Winston Churchill (almost) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'has soma location' (RO:0002100) should not have a range restriction to CARO's 'connected anatomical structure' (CARO:0000003), but rather to 'material anatomical entity' (CARO:0000006), which does not state anything about the "connectedness" of the entity that a neuron's soma may be located in.
closes #702