New terms from issue 710 #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdduncan
requested changes
May 25, 2023
There was a problem hiding this comment.
Please change created_by annotation to either dcterms:creator or dcterms:contributor. I prefer the latter, but the former is acceptable too.
There has been a lot of discussion within the Foundry about standardizing which annotation is used for term creation attribution. You may not be aware of these discussions. @matentzn or @cthoyt can weigh in if they wish to provide more background.
Replaced created_by annotation with dcterms:contributor for both terms.
|
@wdduncan I changed it to dcterms:contributor for both of the new terms. |
wdduncan
approved these changes
May 25, 2023
|
@wdduncan Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds terms 'positively correlated with' and 'negatively correlated with' from issue #710