Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SWRL variables to use valid URN format. #776

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Rename SWRL variables to use valid URN format. #776

merged 1 commit into from
Dec 15, 2023

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Dec 15, 2023

This change updates the URN format used by SWRL variables to match the URN spec. See this old OWL API issue: owlcs/owlapi#732

I assume these variables were created sometime before the OWL API fix. Fixing this will quiet some complaints from RDF validators like this:

09:30:18 WARN  riot            :: [line: 16707, col: 76] {W107} Bad URI: <urn:swrl#y> Code: 61/SCHEME_PATTERN_MATCH_FAILED in PATH: The scheme specific syntax rules are violated.
09:30:18 WARN  riot            :: [line: 16722, col: 68] {W107} Bad URI: <urn:swrl#x> Code: 61/SCHEME_PATTERN_MATCH_FAILED in PATH: The scheme specific syntax rules are violated.
09:30:18 WARN  riot            :: [line: 16723, col: 68] {W107} Bad URI: <urn:swrl#z> Code: 61/SCHEME_PATTERN_MATCH_FAILED in PATH: The scheme specific syntax rules are violated.

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I dont really know much about the wider context. Can you give me a sense of wether there are any risks involved in this change?

@balhoff
Copy link
Member Author

balhoff commented Dec 15, 2023

A risk might be that I used the wrong updated format for the IRIs, and then Protege wouldn't show you the variable name properly when you try to edit the rules. But I looked at the new version in Protege and the rules look the same.

@matentzn
Copy link
Contributor

Alright, thanks. I leave it in @anitacaron hands to push this forward :)

@balhoff balhoff merged commit 7a15a19 into master Dec 15, 2023
1 check passed
@balhoff balhoff deleted the swrl-vars branch December 15, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants