Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024-04-24 Release #795

Merged
merged 8 commits into from
May 1, 2024
Merged

2024-04-24 Release #795

merged 8 commits into from
May 1, 2024

Conversation

anitacaron
Copy link
Collaborator

No description provided.

@anitacaron anitacaron self-assigned this Apr 4, 2024
matentzn
matentzn reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not many changes, just two individuals added? Why making a release for that?

@anitacaron
Copy link
Collaborator Author

Are you checking the whole file, not just the last commit? There are 5 new relationships, two of which you need for OBA.

matentzn
matentzn previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to make a release but I made some minor observations that could be fixed imo

ro-base.obo Outdated Show resolved Hide resolved
ro-base.obo Outdated Show resolved Hide resolved
ro-base.obo Outdated Show resolved Hide resolved
@anitacaron
Copy link
Collaborator Author

Ok, I'll make the changes in another PR.

@anitacaron anitacaron mentioned this pull request Apr 4, 2024
Merged
@anitacaron anitacaron requested a review from matentzn April 4, 2024 15:04
anitacaron
anitacaron commented Apr 4, 2024
View reviewed changes
ro-base.obo Outdated Show resolved Hide resolved
@anitacaron anitacaron mentioned this pull request Apr 5, 2024
Closed
@anitacaron anitacaron marked this pull request as draft April 22, 2024 15:20
@anitacaron anitacaron marked this pull request as ready for review April 24, 2024 10:45
@anitacaron anitacaron changed the title 2024-04-04 Release 2024-04-24 Release Apr 24, 2024
@anitacaron anitacaron merged commit 938e38e into master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

@balhoff balhoff balhoff approved these changes

@matentzn matentzn matentzn approved these changes

Assignees

@anitacaron anitacaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anitacaron @cmungall @balhoff @matentzn