Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Replace pkg/stanza with msrpc fix #1862

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

dpaasman00
Copy link
Contributor

@dpaasman00 dpaasman00 commented Sep 17, 2024

Proposed Change

Adding in a replace for pkg/stanza that includes Dan's fix until the pr gets merged using this commit: observIQ/opentelemetry-collector-contrib@2741093

Checklist
  • Changes are tested
  • CI has passed

@dpaasman00 dpaasman00 requested review from shazlehu and kuiperda and removed request for shazlehu September 17, 2024 11:30
Copy link
Contributor

@kuiperda kuiperda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace looks right

Copy link
Contributor

@kuiperda kuiperda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested and the fix is working.

@dpaasman00 dpaasman00 merged commit 7a96698 into release/v1.60.0 Sep 17, 2024
15 checks passed
@dpaasman00 dpaasman00 deleted the deps/replace-stanza-09-17-2024 branch September 17, 2024 15:12
dpaasman00 added a commit that referenced this pull request Sep 17, 2024
include pkg/stanza replace for dans pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants