Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to go 1.17 #281

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Upgrade to go 1.17 #281

merged 5 commits into from
Apr 14, 2022

Conversation

jessicalins
Copy link
Contributor

  • Use now go mod download all
  • Migrate to //go:build
  • Updated Dockerfile/CI config

@jessicalins
Update go mod with 1.17 go version
a08f73e 
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
@jessicalins
Update Dockerfile and CI config
3053dcc 
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
@jessicalins
Update e2e step
5b879b4 
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
@jessicalins
Update go mod download command, go sum
425e2ef 
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
@jessicalins
Update conditional build comments
00a407e 
Signed-off-by: Jéssica Lins <jessicaalins@gmail.com>
saswatamcode
saswatamcode approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💪

squat
squat approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@squat squat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@squat squat merged commit 33c11ad into observatorium:main Apr 14, 2022
@jessicalins jessicalins mentioned this pull request Apr 14, 2022
Closed
@jessicalins jessicalins deleted the update-go-1-17 branch April 14, 2022 16:06
@jessicalins
Copy link
Contributor Author

@esnible FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessicalins @squat @saswatamcode