Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lint fails on master #46

Closed
rollandf opened this issue Apr 6, 2020 · 1 comment · Fixed by #82
Closed

Make lint fails on master #46

rollandf opened this issue Apr 6, 2020 · 1 comment · Fixed by #82

Comments

@rollandf
Copy link

rollandf commented Apr 6, 2020

commit 11e63ca

main.go:90:2: assignments should only be cuddled with other assignments (wsl)
main.go:173:2: if statements should only be cuddled with assignments (wsl)
main.go:244:2: if statements should only be cuddled with assignments used in the if statement itself (wsl)
main.go:255:2: return statements should not be cuddled if block has more than two lines (wsl)
main.go:411:2: go statements can only invoke functions assigned on line above (wsl)
main.go:412:2: if statements should only be cuddled with assignments (wsl)
main.go:415:2: expressions should not be cuddled with blocks (wsl)
main.go:425:2: only one cuddle assignment allowed before go statement (wsl)
main.go:428:2: return statements should not be cuddled if block has more than two lines (wsl)
main.go:444:4: assignments should only be cuddled with other assignments (wsl)
main.go:441:2: only one cuddle assignment allowed before range statement (wsl)
main.go:449:2: if statements should only be cuddled with assignments (wsl)
main.go:452:2: expressions should not be cuddled with blocks (wsl)
main.go:453:2: return statements should not be cuddled if block has more than two lines (wsl)
main.go:465:2: only one cuddle assignment allowed before if statement (wsl)
main.go:470:2: assignments should only be cuddled with other assignments (wsl)
main.go:483:3: only one cuddle assignment allowed before if statement (wsl)
main.go:480:2: ranges should only be cuddled with assignments used in the iteration (wsl)
main.go:545:3: expressions should not be cuddled with blocks (wsl)
main.go:539:2: only one cuddle assignment allowed before if statement (wsl)
main.go:572:2: declarations should never be cuddled (wsl)
main.go:573:2: expressions should not be cuddled with declarations or returns (wsl)
main_test.go:194:3: only cuddled expressions if assigning variable or using from line above (wsl)
main_test.go:271:3: only cuddled expressions if assigning variable or using from line above (wsl
@brancz
Copy link
Contributor

brancz commented Apr 7, 2020

I've encountered this before as well. We need to pin the version used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants