Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and update go version and dependencies. #82

Merged
merged 7 commits into from
Mar 28, 2022

Conversation

philipgough
Copy link
Collaborator

@philipgough philipgough commented Mar 28, 2022

There is a significantly bigger number of changes in here than I would have liked but I will try to explain the reasoning and what we are actually trying to fix.

Firstly, we have not had CI push a new image in over a year as can be seen by quay dashboard.

So it seems like CI has been broken for some time and lint also failed on the latest commit.

I was not able to run make lint locally (OS X) without panic so I updated the version which bubbled up a number of lint failures, the trivial ones I fixed. Also see #46

The main reason for this change initially was to address some vulnerabilities which have now been rectified by the changes to go.mod. I also noticed #64 so updated those dependencies accordingly and will follow up with a fix for that.

Pulling in the latest k8s.io/* into go.mod brought about the error seen in kubernetes-sigs/json#8 and noticing our intention to move some repos to go 1.1.17 (observatorium/api#262) I updated the Dockerfile and all relevant CI to take care of that here and allow us to proceed with fixing #64

Finally, since we are using scratch in other components, I updated to scratch from distroless image (https://github.com/observatorium/token-refresher/blob/master/Dockerfile#L10) - This can be undone if we prefer.

End result is we are up-to-date and docker scan on the built images shows no vulnerabilities.

Fixes #46
Precursor to closing #64

@philipgough philipgough changed the title WIP: dont merge Fix CI and update go version and dependencies. Mar 28, 2022
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Makes sense to me (:

go.mod Show resolved Hide resolved
@bwplotka bwplotka merged commit 5ce2593 into observatorium:master Mar 28, 2022
@philipgough philipgough deleted the wip branch March 28, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make lint fails on master
2 participants