Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project support for Go 1.16 #8

Closed
MrAlias opened this issue Dec 8, 2021 · 4 comments · Fixed by #9
Closed

Project support for Go 1.16 #8

MrAlias opened this issue Dec 8, 2021 · 4 comments · Fixed by #9

Comments

@MrAlias
Copy link

MrAlias commented Dec 8, 2021 •
edited
Loading

Currently, this project is advertised as supporting Go 1.16 in the project go.mod. However, the project uses functionality introduced in Go 1.17 (1, 2) that does not exist in Go 1.16. This is resulting in downstream packages breaking when trying to build with Go 1.16 and the Go module system not detecting the incompatibility.

Ideally this project would support Go 1.16 as it is still a supported version by the Go language maintainers. If that is not possible, it makes sense to bump the minimum version of Go supported in the main go.mod to allow these errors to be caught by go tooling.
@MrAlias MrAlias mentioned this issue Dec 8, 2021
Closed
@liggitt liggitt mentioned this issue Dec 8, 2021
Merged
@liggitt
Copy link
Contributor

liggitt commented Dec 8, 2021

Opened #9 to be explicit about the go1.17 requirement

@liggitt
Copy link
Contributor

liggitt commented Dec 8, 2021

given go1.16 has just a few weeks of lifetime left before go1.18 is released, I'd prefer to simply be explicit about the go1.17 requirement

@MrAlias
Copy link
Author

MrAlias commented Dec 8, 2021

Thanks 🙏

@gunnar-solo gunnar-solo mentioned this issue Dec 14, 2021
Closed
This was referenced Dec 20, 2021
Closed
Closed
@alexmt alexmt mentioned this issue Jan 18, 2022
Merged
@ngood97-splunk ngood97-splunk mentioned this issue Jan 21, 2022
Closed
@ngood97-splunk
Copy link

Is this supposed to prevent people from being able to install on go 1.16? I think I was still able to and as a result my program won't work until I upgrade to go 1.17.

@zeborg zeborg mentioned this issue Jan 22, 2022
Merged
7 tasks
This was referenced Jan 24, 2022
Closed
Closed
This was referenced Jan 25, 2022
Merged
Merged
brantk-hpe pushed a commit to Cray-HPE/postgres-operator that referenced this issue Jan 26, 2022
CASMPET-5266: Bump go version to 1.17.6
c893ac1 
The build doesn't work with go version 1.16.9. The build was failing
with

```
[2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
```

Looking at bugs like kubernetes-sigs/json#8
it says that go 1.16 is on its way out.

The latest 1.17 is 1.17.6, see
https://go.dev/doc/devel/release#go1.17.minor
brantk-hpe pushed a commit to Cray-HPE/postgres-operator that referenced this issue Jan 26, 2022
CASMPET-5266: Bump go version to 1.17.6
88d64ba 
The build doesn't work with go version 1.16.9. The build was failing
with

```
[2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
```

Looking at bugs like kubernetes-sigs/json#8
it says that go 1.16 is on its way out.

The latest 1.17 is 1.17.6, see
https://go.dev/doc/devel/release#go1.17.minor
brantk-hpe pushed a commit to Cray-HPE/postgres-operator that referenced this issue Jan 26, 2022
CASMPET-5266: Bump go version to 1.17.6
c2001ec 
The build doesn't work with go version 1.16.9. The build was failing
with

```
[2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
```

Looking at bugs like kubernetes-sigs/json#8
it says that go 1.16 is on its way out.

The latest 1.17 is 1.17.6, see
https://go.dev/doc/devel/release#go1.17.minor
brantk-hpe pushed a commit to Cray-HPE/postgres-operator that referenced this issue Jan 26, 2022
CASMPET-5266: Bump go version to 1.17.6
fbb30ed 
The build doesn't work with go version 1.16.9. The build was failing
with

```
[2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
```

Looking at bugs like kubernetes-sigs/json#8
it says that go 1.16 is on its way out.

The latest 1.17 is 1.17.6, see
https://go.dev/doc/devel/release#go1.17.minor
@wallrj wallrj mentioned this issue Jan 27, 2022
Merged
@brantk-hpe brantk-hpe mentioned this issue Jan 27, 2022
Merged
This was referenced Feb 1, 2022
Closed
Closed
@roytman roytman mentioned this issue Feb 3, 2022
Closed
simu added a commit to appuio/component-appuio-cloud that referenced this issue Feb 4, 2022
@simu
k8s.io/apimachinery v0.23 needs go >= 1.17
ffdb726 
Update go.mod to require go 1.17, since the kubernetes-sigs/json package
used by K8s 1.23 uses a go 1.17 feature, cf.
kubernetes-sigs/json#8
simu added a commit to appuio/component-appuio-cloud that referenced this issue Feb 4, 2022
@simu
k8s.io/apimachinery v0.23 needs go >= 1.17
c00fb96 
Update go.mod to require go 1.17, since the kubernetes-sigs/json package
used by K8s 1.23 uses a go 1.17 feature, cf.
kubernetes-sigs/json#8
maiqueb added a commit to maiqueb/whereabouts that referenced this issue Feb 7, 2022
@maiqueb
build: bump k8s version to 1.23.3
ec0079b 
Bumping to k8s 1.23.3 requires the golang version to be bumped up to
1.17, since the json version it uses relies on functionality added in
it.

[0] - kubernetes-sigs/json#8

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb added a commit to maiqueb/whereabouts that referenced this issue Feb 7, 2022
@maiqueb
build: bump k8s version to 1.23.3
9b4816e 
Bumping to k8s 1.23.3 requires the golang version to be bumped up to
1.17, since the json version it uses relies on functionality added in
it.

[0] - kubernetes-sigs/json#8

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@sethvargo sethvargo mentioned this issue Feb 8, 2022
Closed
@shubham1172 shubham1172 mentioned this issue Feb 16, 2022
Merged
1 task
martin-g added a commit to martin-g/volcano that referenced this issue Feb 22, 2022
@martin-g
Upgrade Golang to 1.17.7
b83c090 
Related-to: kubernetes-sigs/json#8
Related-to: kubernetes-sigs/controller-tools#643

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
This was referenced Feb 22, 2022
Closed
Closed
martin-g added a commit to martin-g/volcano that referenced this issue Feb 23, 2022
@martin-g
Upgrade Golang to 1.17.7
1bfe50d 
Related-to: kubernetes-sigs/json#8
Related-to: kubernetes-sigs/controller-tools#643

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@philipgough philipgough mentioned this issue Mar 28, 2022
Merged
@creydr creydr mentioned this issue May 6, 2022
Merged
@benluddy benluddy mentioned this issue Jul 20, 2022
Merged
estahn added a commit to estahn/k8s-image-swapper that referenced this issue Sep 7, 2022
@estahn
chore: bump golang version
f8e6ae9 
see kubernetes-sigs/json#8
estahn added a commit to estahn/k8s-image-swapper that referenced this issue Sep 7, 2022
@estahn
chore: bump golang version
da8c7c9 
see kubernetes-sigs/json#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify go1.17 is required liggitt/json
3 participants
@liggitt @MrAlias @ngood97-splunk