Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test csi-lib with Go 1.17 #621

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jan 27, 2022

In upgrading csi-lib to depend on cert-manager 1.7 it dragged in a library which will only compile with Go 1.17

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager labels Jan 27, 2022
@wallrj wallrj requested a review from munnerz January 27, 2022 14:49
@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2022
@JoshVanL
Copy link
Contributor

JoshVanL commented Feb 2, 2022

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 5496d2e into cert-manager:master Feb 2, 2022
@jetstack-bot
Copy link
Contributor

@wallrj: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-csi-lib-presubmits.yaml using file config/jobs/cert-manager/csi-lib/cert-manager-csi-lib-presubmits.yaml

In response to this:

In upgrading csi-lib to depend on cert-manager 1.7 it dragged in a library which will only compile with Go 1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj deleted the csi-lib-go-1.17 branch March 16, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants