-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install controller-gen failed: sf.IsExported undefined #643
Comments
+1 |
2 similar comments
+1 |
+1 |
Same issue |
I've solved this problem by upgating golang to v1.17. Not sure whether it is a bug for v1.16 or not. |
Can it be solved by not upgating golang to v1.17? |
Unfortunately, I tried some ways but all failed. |
@Thor-wl Updating to
Updating to latest golang is solving this issue ? |
Yes |
cc |
I believe this is related: kubernetes-sigs/json#8 |
+1 |
Same issue here, trying to bump golang version, but it causes massive refactor to lots of other components. Any alternative options? |
* Upgraded logr version to v1.2.2, upgraded sigs.k8s.io/controller-runtime to v0.11.0 - kubernetes-sigs/controller-runtime#1607, upgraded cert-manager version to v1.7.1 Signed-off-by: Nishanth Solomon <solonish@amazon.com> * Changed NullLogger to Discard - NullLogger is deprecated https://pkg.go.dev/github.com/go-logr/logr@v0.4.0/testing#NullLogger Signed-off-by: Nishanth Solomon <solonish@amazon.com> * Changed TestLogger to NewTestLogger - https://github.com/go-logr/logr/releases/tag/v1.1.0 Signed-off-by: Nishanth Solomon <solonish@amazon.com> * Updated to golang:1.17 - kubernetes-sigs/controller-tools#643 Signed-off-by: Nishanth Solomon <solonish@amazon.com>
+1 |
same here with Go version 1.16.5, |
Related-to: kubernetes-sigs/json#8 Related-to: kubernetes-sigs/controller-tools#643 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Related-to: kubernetes-sigs/json#8 Related-to: kubernetes-sigs/controller-tools#643 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
The same problem is in go1.16, which lower version can solve this problem? Thanks |
Not observed this issue in v1.17.8 |
Edit: MR #639 introduced a new version of |
The install guide for operator-sdk says that go 1.16 is required, is that not the case any more? |
HI @dgloe-hpe, The SDK will use go get to check this one, see https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v3/memcached-operator/Makefile#L150-L153 and inform the version. So each SDK bin/release is compatible with which does. The doc shared here is outdated because that should match with the latest release and the latest one uses go 1.17, see: https://github.com/operator-framework/operator-sdk/blob/v1.18.1/go.mod#L3 So, could you please raise an issue against the SDK repo asking for the doc be updated and have the info that the go version needs to be >= 1.17 < 1.18? Also, feel free to contribute with by pushing a PR. Your collab is very welcome. |
Regards this issue, controller-tools is using go 1.17 and have it solved. See its latest release 0.8.0: https://github.com/kubernetes-sigs/controller-tools/blob/v0.8.0/go.mod#L3 So, I am closing this one. however, if anyone need help in the future regards this one then please feel free to raise a new issue. |
the same issue with you on go 1.16. Fixed after upgrade to go1.18..... |
Ran: - go get github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/clientset/versioned - go mod tidy -go=1.17 && go mod vendor Need to use go1.17 as go1.16 runs into kubernetes-sigs/controller-tools#643
…ls#643 Signed-off-by: Michael Shen <mshen@redhat.com>
…ls#643 Signed-off-by: Michael Shen <mshen@redhat.com>
The text was updated successfully, but these errors were encountered: