-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] WINC-818: [test] Fix upgradeable condition test #1347
[release-4.9] WINC-818: [test] Fix upgradeable condition test #1347
Conversation
@saifshaikh48: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Might be running into kubernetes-sigs/controller-tools#643 |
776ad9a
to
7c90206
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, saifshaikh48 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold
|
@saifshaikh48 Please update this PR when you have a chance. |
This commit fixes an issue where the upgradeable condition was not being tested in the e2e test suite. This was the case because the OPERATOR_CONDITION_NAME env var is not being set in the CI env when using the OLM upgrade workflow. The recommendation to fix this was to instead get it from the deployment spec as the condition is present once the operator is deployed. The cache client had to be replaced with the OLM client to get the operator condition using current context. (cherry picked from commit 0ffe33d) (cherry picked from commit cee94c5) (cherry picked from commit d64297a)
Ran with go v1.16: - `go get github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/clientset/versioned@v0.19.1` - `go mod tidy && go mod vendor`
7c90206
to
a2a4a87
Compare
updated to import a go1.16 compatible version of the client library |
Build issue resolved. |
/lgtm |
@saifshaikh48: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is a manual cherry-pick of #1339