Update dependencies and bump to Go 1.17 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
force-pushed
the
update-deps
branch
2 times, most recently
from
079a383
to
be4fe69
Compare
squat
reviewed
Apr 4, 2022
|
|
||
| RUN apk add ca-certificates --no-cache | ||
| RUN apk add ca-certificates --no-cache make && update-ca-certificates |
There was a problem hiding this comment.
We need to copy the car certificates into the final container now
There was a problem hiding this comment.
Good catch. Done
squat
reviewed
Apr 4, 2022
|
|
||
| RUN make build | ||
|
|
||
| FROM scratch |
onprem
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes is similar to what we did in thanos-recieve-controller #82 and essentially, trying to improve our situation in regards to production readiness.
I've update the Go version to 1.17 and upgrade our dependencies, some of which were deprecated or contained vulnerabilities.
The linter version has been updated because the older version was not executable on OS X.
To keep in sync with our other components and to reduce the attack surface of the image I've updated to using a
scratchimage. I had a quick look at the code and can't see any reason why this would be an issue but perhaps I missed something in that regards.