Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix error color at clipping is not displayed on horizontal meter #11209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

norihiro
Copy link
Contributor

@norihiro norihiro commented Aug 28, 2024

Description

Removed the condition if (int(magnitude) != 0), which is not there in VolumeMeter::paintVMeter.

Motivation and Context

When the clipping happens on an audio source, the error color (red by default) is not displayed on the horizontal volume meter.

There are two rendering functions VolumeMeter::paintHMeter and VolumeMeter::paintVMeter. These functions should be identical except for the coordinate calculation.

How Has This Been Tested?

OS: Fedora 39

  1. Prepare an audio source that outputs continuous tone.
  2. Apply a gain filter
  3. Decrease and increase the gain and check the volume meter.
master this PR
https://github.com/user-attachments/assets/9b674f5c-ee40-4d4c-88cd-3250c7623adc https://github.com/user-attachments/assets/1766d7c6-ce97-4d2c-8c7d-10df4f58a1e0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants