UI: Fix error color at clipping is not displayed on horizontal meter #11209
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the condition
if (int(magnitude) != 0)
, which is not there inVolumeMeter::paintVMeter
.Motivation and Context
When the clipping happens on an audio source, the error color (red by default) is not displayed on the horizontal volume meter.
There are two rendering functions
VolumeMeter::paintHMeter
andVolumeMeter::paintVMeter
. These functions should be identical except for the coordinate calculation.How Has This Been Tested?
OS: Fedora 39
Types of changes
Checklist: