UI: Fix crash when creating scene collections with "unsafe" names

[PatTheMav]

Description

Fixes possible crash when a new scene collection is created with a name that consists "unsafe" characters.

Motivation and Context

Scene collection names that are not considered "safe" by OBS Studio get a changed JSON file name with incompatible characters replaced.

The refactored scene collection implementation uses the Load function to either activate an existing scene collection or create a new one if it does not exist.

The Load function however overwrote the scene collection name set in the profile with its own variant based off the "safe" file name, which created a mismatch with the code that created the collection data model.

As the Load function is only called by ActivateSceneCollection (which itself already sets the name and filename for the collection), removal of this superfluous code in the Load function also fixes the issue.

How Has This Been Tested?

Tested on Windows 11 with a scene collection named "New Collection" which will be automatically stored in "New_Collection.json".

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[RytoEX]

These lines were originally added as part of #11038 to fix a bug where scene collections could be erased (#11037). Can we confirm that that bug does not resurface from removing these lines?

[PatTheMav]

The values are always set by ActivateCollection now, right before Load itself is called:

obs-studio/UI/window-basic-main-scene-collections.cpp

Lines 758 to 763 in 06642fd

	config_set_string(App()->GetUserConfig(), "Basic", "SceneCollection",
	collection.name.c_str());
	config_set_string(App()->GetUserConfig(), "Basic",
	"SceneCollectionFile", collection.fileName.c_str());
	Load(collection.collectionFile.u8string().c_str());

According to MSVC and Xcode that's the only function that calls Load so both config values should always be set with the added bonus that the collection name is not downgraded to a "safe" name for the file system.