Email verification

[SKairinos]

This change is 

[faucomte97]

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @SKairinos)

---

vite.config.ts line 33 at r1 (raw file):

      "@mui/x-date-pickers/AdapterDayjs",
      "dayjs",
      "dayjs/locale/en-gb",

Why were these added here?

Code quote:

      "@mui/x-date-pickers",
      "@mui/x-date-pickers/AdapterDayjs",
      "dayjs",
      "dayjs/locale/en-gb",

---

src/images/paper_plane.png line 0 at r1 (raw file):
Are we able to use an icon instead of a PNG?

---

src/images/sadface.png line 0 at r1 (raw file):
Are we able to use an icon instead of a PNG?

---

src/pages/emailVerification/EmailVerification.tsx line 42 at r1 (raw file):

              "An email has been sent to the address you provided.",
              "Please follow the link within the email to verify your details. This will expire in 1 hour.",
              "If you don't receive the email within the next few minutes, check your spam folder.",

This doesn't match what's currently on the website - happy to address later though if you want, as part of the whole styles / copy check.

Code quote:

              "An email has been sent to the address you provided.",
              "Please follow the link within the email to verify your details. This will expire in 1 hour.",
              "If you don't receive the email within the next few minutes, check your spam folder.",

---

src/pages/emailVerification/Status.tsx line 30 at r1 (raw file):

        ))}
      </Stack>
      <LinkButton to={paths._} style={{ marginTop: 30 }}>

Page seems to be missing the two buttons that redirect to Outlook and Gmail

[SKairinos]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @faucomte97 and @lauracumming)

---

vite.config.ts line 33 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Why were these added here?

Vite does not optimize these dependencies by default since they are only imported in the JS package. Yes, we import the JS package but vite doesn't look at what the JS package imports internally. Therefore, we need to manually inform vite to optimize these dependencies.

---

src/images/paper_plane.png line at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Are we able to use an icon instead of a PNG?

let's ask @lauracumming if we can use this instead
https://mui.com/material-ui/material-icons/?query=paper&selected=Send

---

src/images/sadface.png line at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Are we able to use an icon instead of a PNG?

let's ask @lauracumming if we can use this instead
https://mui.com/material-ui/material-icons/?query=sad&selected=SentimentVeryDissatisfied

---

src/pages/emailVerification/Status.tsx line 30 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Page seems to be missing the two buttons that redirect to Outlook and Gmail

Ah yes, forgot we added those.

[SKairinos]

Reviewable status: 8 of 13 files reviewed, 4 unresolved discussions (waiting on @faucomte97 and @lauracumming)

---

src/pages/emailVerification/EmailVerification.tsx line 42 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

This doesn't match what's currently on the website - happy to address later though if you want, as part of the whole styles / copy check.

Done.

[faucomte97]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

---

src/images/paper_plane.png line at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

let's ask @lauracumming if we can use this instead
https://mui.com/material-ui/material-icons/?query=paper&selected=Send

Please delete

---

src/images/sadface.png line at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

let's ask @lauracumming if we can use this instead
https://mui.com/material-ui/material-icons/?query=sad&selected=SentimentVeryDissatisfied

Please delete

[faucomte97]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lauracumming)

[faucomte97]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

[faucomte97]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)