Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge live branch back into master #223

Merged
merged 15 commits into from
Jun 4, 2023
Merged

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Mar 9, 2023

@tmcgilchrist
Copy link
Contributor

Can we simplify the ocurrent-deployer setup for this project once this is merged?

@dra27 dra27 marked this pull request as ready for review June 1, 2023 08:12
@dra27
Copy link
Member Author

dra27 commented Jun 1, 2023

This PR is a "fake" merge commit - that is, it leaves the tree of master exactly at the tree of live, discarding the master tree completely. The HEAD commit of this PR (64e8434), therefore, is identical to upstream/live @ 937ee34.

Just to show the working: live and master have an effective common base of bba77e7 (that's not the merge-base, but earlier, since #205 was reverted on master). Ignoring PRs which were then merged to master and subsequently reverted, master since then contains #216, which is not needed as live has #215 instead, and #224, which is already on live.

@tmcgilchrist
Copy link
Contributor

Thank you for fixing this @dra27 It will be great to get this piece of infrastructure finally sorted out.

@avsm
Copy link
Contributor

avsm commented Jun 3, 2023

I don't understand all the branching and merging going on here I'm afraid. What needs to happen next to get this merged, and opam2web building off main again, and subsequently the expired PGP key at ocaml/infrastructure#46 updated?

@dra27
Copy link
Member Author

dra27 commented Jun 3, 2023

This PR just needs approving and merging! All it does is make master the same as live without any force pushing.

@dra27
Copy link
Member Author

dra27 commented Jun 3, 2023

I don't know if the output from the visualizer is easier to interpret than GitHub's interface: this PR is literally one commit merging the live branch (which is presently deployed to opam.ocaml.org) into master (which is no longer deployed), leaving master with exactly the same content as live.
image
(the "working" above is just an explanation for "copying" live to master doesn't lose anything)

Copy link
Contributor

@avsm avsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I believe dra27 :-)

@avsm avsm merged commit 3bd3529 into ocaml-opam:master Jun 4, 2023
@avsm
Copy link
Contributor

avsm commented Jun 4, 2023

But now, we do need to update the signing key live -- does that just have to go to the master branch and then pushed to live to be picked up the deployer?

@dra27 dra27 deleted the live-into-master branch June 4, 2023 16:33
@dra27
Copy link
Member Author

dra27 commented Jun 4, 2023

That's right, yes - PR to master with the new key, it can be test-pushed to staging before merging (though probably not necessary for a static file) but should only be pushed to live after the PR's been merged on master. With this PR merged, the instructions/notes on https://github.com/ocaml-opam/opam2web#deployment are now actually correct 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants