Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [directory targets] Fix promotion of directory targets in some cases #10931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 17, 2024

  1. [fix] [directory targets] Fix promotion of directory targets in some …

    …cases
    
    When the promoted directory has sub-directories with only other
    sub-directories inside, the map will miss that directory and it will
    not be properly re-created, failing at children creation time.
    
    I am not sure I fully follow the logic here (cc: @rleshchinskiy).
    
    The current test case works for me (TM), if we revert the fix we get:
    
    ```
    Error: Cannot promote files to "node_modules/node-cmake/node_modules/ansi-regex".
    Reason: opendir(node_modules/node-cmake/node_modules/ansi-regex): No such file or directory
    ```
    
    Regression in b1c339b / ocaml#9407
    
    Closes ocaml#10609 .
    
    Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
    ejgallego committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5019bce View commit details
    Browse the repository at this point in the history