Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurator: pkg-config plugin uses pkgconf and --personality=TARGET by default #10937

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Configurator: pkg-config plugin uses pkgconf and --personality=TARGET by default #10937

wants to merge 5 commits into from

Commits on Sep 19, 2024

  1. configurator: Allow to specify a path in PKG_CONFIG 

    This makes the implementation of `which` in configurator closer to the one of stdune.

Signed-off-by: Pierre Boutillier <pierre.boutillier@laposte.net>
    @pirbo
    pirbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5349f6f View commit details
    Browse the repository at this point in the history

  2. Configurator: try to call pkgconf before failing back to pkg-config 

    Pkgconf is a modern implementation of the "pkg-config freedesktop standard". Linux distros actually use pkgconf as their
pkg-config implementation and provide a in place replacement. (Homebrew packages both and is the last place I found where you can get the historical implementation).
It is always OK to call pkgconf for pkg-config all the CLI and outputs within the standard are following the standard :-).

Cygwin pkg-config package though provides pkgconf but does not provide the alias pkg-config forcing us to uptream the switch to the tool name instead of the standard.

Signed-off-by: Pierre Boutillier <pierre.boutillier@laposte.net>
    @pirbo
    pirbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c584ef3 View commit details
    Browse the repository at this point in the history

  3. Configurator tests: toy pkg-config cleaned and renamed into pkgconf 

    Signed-off-by: Pierre Boutillier <pierre.boutillier@laposte.net>
    @pirbo
    pirbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    81a38f9 View commit details
    Browse the repository at this point in the history

  4. Configurator: add by default --personality=@target@ to pkgconf calls 

    Specifying a personality is only useful when cross-compiling (which you do when you use mingw on Windows) but
(nearly) never harmful as pkgconf installs a default.personality which it uses for all triplets (that parses
therefore the nearly) it hasn't a explicit personality for.

Signed-off-by: Pierre Boutillier <pierre.boutillier@laposte.net>
    @pirbo
    pirbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bd825f5 View commit details
    Browse the repository at this point in the history

  5. configurator tests: BAD made them not portable 

    Signed-off-by: Pierre Boutillier <pierre.boutillier@laposte.net>
    @pirbo
    pirbo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c3da4c3 View commit details
    Browse the repository at this point in the history