refactor: dune file evaluation #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dune files written in OCaml syntax must be evaluated once per run. While this was maintained by keeping all the stanzas in one data structure in the super context, now any memoizing function can get the list of stanzas. This change makes sure that we don't memoize the evaluated stanzas incorrectly. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: F1290BF8-C67B-418F-82D8-D30FF328B590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune files written in OCaml syntax must be evaluated once per run. While
this was maintained by keeping all the stanzas in one data structure in
the super context, now any memoizing function can get the list of
stanzas. This change makes sure that we don't memoize the evaluated
stanzas incorrectly.