rename user-rebindable {LINK,COMP}FLAGS into OCB_{LINK,COMP}FLAGS #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Except for the lack of a changes entry this looks good (also I suspect you did a |
|
@gasche, I think we should merge this one |
This should help avoid build failures due to unintential redefined-variable capture, see ocaml#301. (failure report by Samik Shrotriya)
hhugo
force-pushed
the
avoid-makefile-env-collision
branch
from
5324278
to
3130462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help avoid build failures due to unintential
redefined-variable capture, see #301.
(failure report by Samik Shrotriya)