Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to opam.2.2 #336

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Switch to opam.2.2 #336

merged 4 commits into from
Jun 20, 2024

Conversation

hhugo
Copy link
Collaborator

@hhugo hhugo commented Jun 12, 2024

And no longer rely on patched ocaml compilers from the opam-repository-mingw repo.

The PR removes OCaml 4.08 .. 4.12 on windows from the CI because this setup is not yet available in the upstream opam repo.

@hhugo
Copy link
Collaborator Author

hhugo commented Jun 12, 2024

cc @dra27, @smorimoto, @kit-ty-kate

And no longer rely on patched ocaml compiler from the opam-repository-mingw repo.
@hhugo hhugo marked this pull request as ready for review June 15, 2024 06:52
Hugo Heuzard added 2 commits June 16, 2024 10:43
Co-authored-by: Sora Morimoto <sora@morimoto.io>
@hhugo
Copy link
Collaborator Author

hhugo commented Jun 20, 2024

@gasche, @kit-ty-kate, this is now ready for review.
History should be squashed.

@hhugo hhugo requested review from gasche and kit-ty-kate June 20, 2024 06:30
@gasche
Copy link
Member

gasche commented Jun 20, 2024

I don't understand much of this CI stuff, but the code looks simpler after than before, so I am okay with it. Removing Windows testing before 4.12 is also fine.

@hhugo hhugo merged commit fa65edf into master Jun 20, 2024
15 checks passed
@hhugo hhugo deleted the opam22 branch June 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants