[fl_dynload] Allow overriding low-level module loader #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, `Fl_dynload.load_packages` will unconditionally call `Dynlink.loadfile` to load each particular compilation unit. This works fine in almost all our scenarios, however when compiling Web Workers with JSOO, we have found that `Dynlink.loadfile` takes a very long time as it will compile `.cma` files to `.js`. In the case of jsCoq and `coq-lsp` this compilation process is too heavy. Prior to us using `findlib`, we used to trap all calls from Coq to `Dynlink.loadfile`, and we used a pre-compiled `.js` version which was much much faster. This patch makes it possible for users of `Fl_dynload.load_packages` to override the call to `Dynlink.loadfile` as to for example implement the above cache setup, or to do other kinds of instrumentations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch,
Fl_dynload.load_packageswill unconditionally callDynlink.loadfileto load each particular compilation unit.This works fine in almost all our scenarios, however when compiling Web Workers with JSOO, we have found that
Dynlink.loadfiletakes a very long time as it will compile.cmafiles to.js.In the case of jsCoq and
coq-lspthis compilation process is too heavy. Prior to us usingfindlib, we used to trap all calls from Coq toDynlink.loadfile, and we used a pre-compiled.jsversion which was much much faster.This patch makes it possible for users of
Fl_dynload.load_packagesto override the call toDynlink.loadfileas to for example implement the above cache setup, or to do other kinds of instrumentations.