Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add challenge DF tables, routes, parsers #57

Merged
merged 13 commits into from
Jun 27, 2023

Conversation

trizin
Copy link
Collaborator

@trizin trizin commented Jun 22, 2023

Fixes #55

Changes proposed in this PR:

  • Add DF challenge tables, routes, parsers.
  • Updated rewardsSummary table to aggregate rewards from challenge DF

@trizin trizin linked an issue Jun 22, 2023 that may be closed by this pull request
@trizin trizin requested a review from idiom-bytes June 22, 2023 13:13
SELECT predictoor_addr AS LP_addr, 0 AS passive, 0 AS curating, OCEAN_amt FROM predictoor_rewards WHERE round = ?
) AS foo GROUP BY LP_addr`,
[round, round, round, round]
INSERT INTO rewards_summary(LP_addr, passive_amt, curating_amt, predictoor_amt, challenge_amt, round)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

round INT NOT NULL,
PRIMARY KEY(winner_addr, round)
)`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

expect(parseCsv).toHaveBeenCalledTimes(14)
expect(crypto.createHash).toHaveBeenCalledTimes(14)
expect(mockHash.update).toHaveBeenCalledTimes(14)
expect(mockHash.digest).toHaveBeenCalledTimes(14)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@trizin trizin merged commit 07bec14 into main Jun 27, 2023
@trizin trizin deleted the issue55-add-challenge-df-tables branch June 27, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Challenge DF Tables
2 participants