-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency rehype-highlight to v5 #302
Conversation
I may need to handle this one manually since I'm not sure if the breaking changes are affecting current transformations. |
I'll let you handle it then! 😉 |
bd2dbd0
to
9fa77ee
Compare
9fa77ee
to
0bc8495
Compare
0bc8495
to
0d3ef02
Compare
0d3ef02
to
136be7a
Compare
…nto renovate/rehype-highlight-5.x # Conflicts: # package.json # yarn.lock
I've upgraded the whole
code: 'ERR_REQUIRE_ESM' I need to investigate this further, no idea what's wrong. |
Listing changes from all packages upgraded to check if I'm missing something 🤔 |
Alright, issue found: it turns out Webpack v5 used by Next.js is not ready yet for ESM packages. The whole info is in this issue: vercel/next.js#23725 This has been solved in the canary of Next.js (I have confirmed this locally), but I'll wait until it's released in the stable channel to upgrade everything. I'll leave this PR on hold then until Next.js releases compatibility for ESM packages. |
Hooray, you found the problem! 😄 Okay, so we need to wait until Next.js updates before we can use the newer version of |
It's here! https://nextjs.org/blog/next-11-1 I'll try to get all this upgraded tomorrow. |
Yay!!!! 😄 I'll go read the blog. |
…ight-5.x # Conflicts: # yarn.lock
The whole unified/rehype/remark ecosystem is upgraded and working fine with Next.js v11.1 now. This PR is ready to go! |
This PR contains the following updates:
4.1.0
->5.0.0
Release Notes
rehypejs/rehype-highlight
v5.0.0
Compare Source
dfa5a4b
Use ESMChange:
Learn more about ESM in this guide
c87da55
Updatelowlight
This makes
rehype-highlight
much faster and viable for use in browsershighlight.js
to v11, which improves resultsfa5fcf4
Add JSDoc based types84b5ce2
Fix code being droppedConfiguration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.