Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove extraneous command to update npm #565

Merged
merged 2 commits into from
Jul 24, 2024
Merged

ci: remove extraneous command to update npm #565

merged 2 commits into from
Jul 24, 2024

Conversation

wolfy1339
Copy link
Member

It is not used currently

Resolves #ISSUE_NUMBER


Before the change?

  • There was a command in the test.yml workflow file to update NPM that was unused because it was only run on Node 14
  • We don't support Node 14 anymore

After the change?

  • Removes the extraneous NPM update that wasn't run

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 23, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd merged commit 4015ff8 into main Jul 24, 2024
7 checks passed
@nickfloyd nickfloyd deleted the cleanup-ci branch July 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants