-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add override for bad usage of anyOf
#349
Conversation
cc552d7
to
d7a94e2
Compare
d7a94e2
to
34c859d
Compare
34c859d
to
0237b4c
Compare
For easier reviewing, since GitHub doesn't want to show the diff online, or generate a diff/patch file, here are the diffs for each commit. 0001-fix-add-override-for-bad-usage-of-anyOf.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear to me why the diff isn't displaying. The changes in your linked text files look reasonable to me as a workaround while we wait for the upstream issue to be fixed.
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See octokit/types.ts#534
Behavior
Before the change?
anyOf
, trying to use it to make one property required at a time (either or)After the change?
oneOf
instead, as both properties can't be present at the same time, and put the different properties in 2 schemas inside of thatoneOf
Other information
openapi-typescript
v6, as they went more strict on the openapi spec parsinganyOf
to require either or of certain properties in definitions github/rest-api-description#2510Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug