Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated types to be compatible with the latest @octokit/types updates #523

Closed
wants to merge 1 commit into from

Conversation

jtamsut
Copy link

@jtamsut jtamsut commented Apr 26, 2023

There were changes to @octokit/types (see this commit) that is breaking stuff. Here's a fix.

Resolves #ISSUE_NUMBER


Behavior

Before the change?

After the change?

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Apr 26, 2023
@wolfy1339
Copy link
Member

Thanks for this fix. However this will only help with this plugin, and conflict with #518.

It would be better to wait for the proper fix to land, and all modules will be updated accordingly.

@wolfy1339
Copy link
Member

The types will still error even with this PR due to octokit/types.ts#528

Duplicate of #518

@wolfy1339 wolfy1339 closed this Apr 26, 2023
@wolfy1339 wolfy1339 added the Duplicate There are other issues and PRs like this label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate There are other issues and PRs like this Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants