fix: un-encode {repo} URL parameter when it's set to `${{ github.repo…

…sitory }}` (#72)
octokit · Jan 26, 2021 · 7a09f9e · 7a09f9e
1 parent 2375950
commit 7a09f9e
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 18 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -21,6 +21,7 @@ jobs:
           owner: octokit
           repo: request-action
       - run: "echo latest release: '${{ steps.get_latest_release.outputs.data }}'"
+
       # Create check run
       - name: "Create check run for ${{ github.sha }}"
         uses: ./
@@ -29,9 +30,6 @@ jobs:
           route: POST /repos/{owner}/{repo}/check-runs
           owner: octokit
           repo: request-action
-          mediaType: | # The | is significant!
-            previews: 
-              - antiope
           name: "Test check run"
           head_sha: ${{ github.sha }}
           output: | # The | is significant!
@@ -51,11 +49,17 @@ jobs:
           route: PATCH /repos/{owner}/{repo}/check-runs/{check_run_id}
           owner: octokit
           repo: request-action
-          mediaType: | # The | is significant!
-            previews: 
-              - antiope
           check_run_id: ${{ fromJson(steps.create_check_run.outputs.data).id }}
           conclusion: "success"
           status: "completed"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      # See https://github.com/octokit/request-action/issues/71
+      - name: "Un-encode {repo} URL parameter when it's set to github.repository"
+        uses: ./
+        with:
+          route: GET /repos/{repository}
+          repository: ${{ github.repository }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/README.md b/README.md
@@ -50,9 +50,6 @@ jobs:
           route: POST /repos/{owner}/{repo}/check-runs
           owner: octokit
           repo: request-action
-          mediaType: | # The | is significant!
-            previews: 
-              - antiope
           name: "Test check run"
           head_sha: ${{ github.sha }}
           output: | # The | is significant!
@@ -71,9 +68,6 @@ jobs:
           route: PATCH /repos/{owner}/{repo}/check-runs/{check_run_id}
           owner: octokit
           repo: request-action
-          mediaType: | # The | is significant!
-            previews: 
-              - antiope
           check_run_id: ${{ fromJson(steps.create_check_run.outputs.data).id }}
           conclusion: "success"
           status: "completed"

diff --git a/index.js b/index.js
@@ -16,16 +16,28 @@ async function main() {
       core.info(`> ${name}: ${value}`);
     }
 
+    // workaround for https://github.com/octokit/request-action/issues/71
+    // un-encode "repo" in /repos/{repo} URL when "repo" parameter is set to ${{ github.repository }}
+    const { url, body, ...options } = octokit.request.endpoint(
+      route,
+      parameters
+    );
+    const requestOptions = {
+      ...options,
+      data: body,
+      url: url.replace(
+        /\/repos\/([^/]+)/,
+        (_, match) => "/repos/" + decodeURIComponent(match)
+      ),
+    };
+
     core.debug(`route: ${inspect(route)}`);
     core.debug(`parameters: ${inspect(parameters)}`);
-    core.debug(
-      `parsed request options: ${inspect(
-        octokit.request.endpoint(route, parameters)
-      )}`
-    );
+    core.debug(`parsed request options: ${inspect(requestOptions)}`);
 
     const time = Date.now();
-    const { status, headers, data } = await octokit.request(route, parameters);
+
+    const { status, headers, data } = await octokit.request(requestOptions);
 
     core.info(`< ${status} ${Date.now() - time}ms`);