Skip to content

Commit

Permalink
feat: v11 (#561)
Browse files Browse the repository at this point in the history
* remove timeout and agent from requestoptions because of the fetch breaking change

BREAKING CHANGE: Replace support for Node.js http(s) Agents with documentation on using fetch dispatchers instead
  • Loading branch information
nickfloyd authored Jul 7, 2023
1 parent 76f81e8 commit 2fc7576
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/RequestRequestOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ import type { Signal } from "./Signal";
* Octokit-specific request options which are ignored for the actual request, but can be used by Octokit or plugins to manipulate how the request is sent or how a response is handled
*/
export type RequestRequestOptions = {
/**
* Node only. Useful for custom proxy, certificate, or dns lookup.
*
* @see https://nodejs.org/api/http.html#http_class_http_agent
*/
agent?: unknown;
/**
* Custom replacement for built-in fetch method. Useful for testing or request hooks.
*/
Expand All @@ -19,10 +13,6 @@ export type RequestRequestOptions = {
* Use an `AbortController` instance to cancel a request. In node you can only cancel streamed requests.
*/
signal?: Signal;
/**
* Node only. Request/response timeout in ms, it resets on redirect. 0 to disable (OS limit applies). `options.request.signal` is recommended instead.
*/
timeout?: number;

[option: string]: any;
};

0 comments on commit 2fc7576

Please sign in to comment.