Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: dist-types/index.d.ts is not present in the published NPM package #525

Closed
1 task done
wolfy1339 opened this issue Apr 19, 2023 · 2 comments · Fixed by #526
Closed
1 task done

[BUG]: dist-types/index.d.ts is not present in the published NPM package #525

wolfy1339 opened this issue Apr 19, 2023 · 2 comments · Fixed by #526
Labels
released Type: Bug Something isn't working as documented, or is being fixed

Comments

@wolfy1339
Copy link
Member

wolfy1339 commented Apr 19, 2023

What happened?

The dist-types folder is not getting published to npm

Apparently, since npm 9 the file pattern matching for npm publish has changed, but nothing was reported in their Changelog (I'm assuming it's an unintended change).

Versions

@octokit/types 9.1.0

Relevant log output

N/A

Code of Conduct

  • I agree to follow this project's Code of Conduct
@pragmaticivan
Copy link

I can replicate that.

@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants