feat: reply after 9s with 202 status #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #185 right? |
Yes 👍🏼
I think it makes sense to finish up the rewrite of the tests to Jest & TypeScript first :) |
|
I'll have to finish this on Friday latest. It might create some merge conflicts with your work on rewriting tests to TypeScript I'm afraid, but I need to finish up Probot v10 and this will become a blocker by then |
From my side it's fine. I will be with no laptop for the next to weeks. I would ask to @wolfy1339 |
gr2m
force-pushed
the
185/avoid-timeout
branch
from
017e05b
to
5e21bcd
Compare
gr2m
force-pushed
the
185/avoid-timeout
branch
from
5e21bcd
to
5c8ed8f
Compare
gr2m
changed the title
gr2m
force-pushed
the
185/avoid-timeout
branch
from
5c8ed8f
to
eabb99a
Compare
gr2m
force-pushed
the
185/avoid-timeout
branch
from
14f3131
to
e04699f
Compare
|
🎉 This PR is included in version 7.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wolfy1339
added a commit
that referenced
this pull request
Aug 22, 2020
- Pull in the relevant types package for `@sinonjs/fake-timers` - Convert those tests from tap to Jest - Add some Typescript types to those tests
wolfy1339
added a commit
that referenced
this pull request
Aug 25, 2020
- Pull in the relevant types package for `@sinonjs/fake-timers` - Convert those tests from tap to Jest - Add some Typescript types to those tests
wolfy1339
added a commit
that referenced
this pull request
Aug 25, 2020
- Pull in the relevant types package for `@sinonjs/fake-timers` - Convert those tests from tap to Jest - Add some Typescript types to those tests
gr2m
pushed a commit
that referenced
this pull request
Aug 25, 2020
* chore(tests): Convert to typescript and use Jest * chore(lint): Run prettier * fix: Add missing closing bracket * chore(lint): Run Prettier * refactor(tests): Replace some tap with jest equivalents - Replace `t.ok()` with `expect().toBeTruthy()` - Replace `t.plan()` with `expect.assertions()` * chore(package): Add types for simple-mock * fix(typescript): Make sure to use the simple-mock types * chore(tests): Migrate integration tests to TypeScript + Jest * chore(tests): Finish most of the Jest transition * fix(typescript): Fix some type errors * fix(tests): Some more fixes * fix(tests): Get tests to run * fix(tests): Fix some jest errors Jest expects functions in the `expect()` function when using the `.toThrow()` property * fix(tests): Fix some type errors * refactor: Remove un-needed argument * fix(tests): Fix various problems in the tests Fix some types Replace some remaining tap functions Ignore some TypeScript type errors, they are there on purpose to test if the function throws an error * test(integration/middlewares): fix mocks to make tests pass * test(middleware): add check to assure the number of assertions expected to run are executed * test(middlewares): fix typing of unit test for middlewares * ♻️ refactor(jest): use toHaveBeenCalled instead of toHaveBeenCalledTimes(1) * 🚨 test(event-handler-test): add missing done() callback to make async test to wait until all expect * tests: Set node environment in Jest config * test(server-test): mock errorHandler using jest.fn() (#198) * tests: Fix tests after #190 - Pull in the relevant types package for `@sinonjs/fake-timers` - Convert those tests from tap to Jest - Add some Typescript types to those tests * fix(typescript): Fix some type errors in the tests * test(types): add missing types to variables and paramters on event-handler-test (#212) * Fix sign test type compilation error (#213) * test(server-test): fix typescript errors (#214) * test(middleware-test): add test coverage for middleware when there is a timeout (#215) * Revert 2b7c0bb and instead add a ts-ignore statement Adds back the existing error message that was removed * build(aggregate-error): upgrade version to support Custom Errors (#233) * test(sign-test): restore 100% coverage for sign-test (#234) * fix(sign): make sign() parameters non-optional (#237) Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can test this with https://github.com/sinonjs/fake-timers, without needing to wait for 10s in our tests.
If anynone wants to finish this today be my guest, if not I'll finish this up tomorrow
fixes #185