Add user settings to BuildConfig #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
reviewed
Aug 5, 2021
| @@ -316,6 +591,11 @@ impl Revision { | |||
| .host(&target.host) | |||
| .profile("Debug"); | |||
|
|
|||
| for (key, value) in build_config.as_cmake_define_key_values() { | |||
| println!("setting {}={}", key, value); | |||
There was a problem hiding this comment.
Ah, yes - at first I wanted to make sure that the user could see their settings take flight - but then I noticed it's passed in the call to cmake anyway. I'll remove this in a follow up. Thanks for the fast review and merge 🙇 .
|
@schell can you address that one comment in a follow up PR? going to land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanies #5
TVMCMakeSettingstoCMakeSettingsUserSettingsstruct with most cmake settings from cmake.configUserSettingsto being passed and parsed through command line args